FINERACT-2081: Fix Accrual activity - reverse and replayed couple of … #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alberto-art3ch
force-pushed
the
2315-fix-accrual-activity-reverse-and-replayed-couple-of-times-after-backdated-repayment
branch
3 times, most recently
from
7502d1a to
9691e6a
Compare
galovics
approved these changes
Feb 16, 2025
alberto-art3ch
force-pushed
the
2315-fix-accrual-activity-reverse-and-replayed-couple-of-times-after-backdated-repayment
branch
4 times, most recently
from
6804c67 to
2e08ee9
Compare
…isbursementDate setting to be taking into account by periodic accrual job
…isbursementDate setting to be taking into account by periodic accrual job
…isbursementDate setting to be taking into account by periodic accrual job
…isbursementDate setting to be taking into account by periodic accrual job
…times after backdated repayment
alberto-art3ch
force-pushed
the
2315-fix-accrual-activity-reverse-and-replayed-couple-of-times-after-backdated-repayment
branch
from
2e08ee9 to
58aac9c
Compare
|
@alberto-art3ch Kindly squash you commits! |
adamsaghy
reviewed
Feb 24, 2025
| loanTransaction.reverse(); | ||
| } else { | ||
| loanTransaction.updateComponentsAndTotal(principalPortion, interestPortion, feeChargesPortion, penaltyChargesPortion); | ||
| if (currentInstallment.isObligationsMet()) { |
There was a problem hiding this comment.
Please make sure you are not change the transaction date in case the repayment date is later than the installment due date!
adamsaghy
reviewed
Feb 24, 2025
| @@ -122,7 +122,11 @@ public void processAccrualActivityForLoanClosure(@NotNull Loan loan) { | |||
|
|
|||
| if (installmentAccruals.isEmpty()) { | |||
| // No AAT for this installment; create one | |||
| makeAccrualActivityTransaction(loan, installment, installment.getDueDate()); | |||
| LocalDate transactionDate = installment.getDueDate(); | |||
| if (loan.isOverPaid() && installment.getDueDate().isAfter(loan.getOverpaidOnDate())) { | |||
There was a problem hiding this comment.
Why only the overpayment situation? What about it was fully paid? Do we need this at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…times after backdated repayment
Description
Accrual activity is reversed and replayed couple of times after backdated repayment.
FINERACT-2081
selectover them_loan_transactiontableChecklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.