FINERACT-2169: SMS API refactoring and clean up; #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorPavfurious
force-pushed
the
FINERACT-2169-SMS-API
branch
from
0b282ed to
400f3a4
Compare
VictorPavfurious
force-pushed
the
FINERACT-2169-SMS-API
branch
from
400f3a4 to
87e6f6d
Compare
adamsaghy
reviewed
Feb 24, 2025
|
|
||
| @GET | ||
| public String retrieveAll(@Context final UriInfo uriInfo) { | ||
| public Collection<SmsData> retrieveAll() { |
There was a problem hiding this comment.
Should we use List instead?
There was a problem hiding this comment.
Yes, you are right, better use List
adamsaghy
reviewed
Feb 24, 2025
...src/main/java/org/apache/fineract/infrastructure/sms/service/SmsReadPlatformServiceImpl.java
Show resolved
Hide resolved
adamsaghy
reviewed
Feb 24, 2025
| this.jdbcTemplate = jdbcTemplate; | ||
| this.sqlGenerator = sqlGenerator; | ||
| @PostConstruct | ||
| public void init() { | ||
| this.businessRuleMapper = new BusinessRuleMapper(sqlGenerator); |
There was a problem hiding this comment.
Should we just do the initialization at field definition?
private final SmsCampaignMapper smsCampaignMapper = new SmsCampaignMapper();
private final BusinessRuleMapper this.businessRuleMapper = new BusinessRuleMapper(sqlGenerator);
There was a problem hiding this comment.
@adamsaghy what do you think about make this SmsCampaignMapper and BusinessRuleMapper like bean Component and inject via construct with using DI?
I think it will be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.