Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36324] Harden runtime error cases for table builtin functions #26190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dawidwys
Copy link
Contributor

What is the purpose of the change

To stabilize tests checking for runtime exceptions for SQL builtin functions.

It seems, depending on timing tableResult.await() does not always return a runtime exception. The safest way is to request the runtime exception directly from the cluster.

Verifying this change

The tests should pass

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@dawidwys
Copy link
Contributor Author

May I ask you @pnowojski for a review?

@dawidwys dawidwys requested a review from Copilot February 21, 2025 11:14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java:111

  • [nitpick] The interface name TestCaseWithClusterClient is too verbose. Consider renaming it to ClusterClientTestCase.
interface TestCaseWithClusterClient

flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java:104

  • Ensure that the new behavior introduced by MiniClusterClient is covered by tests.
testCase.execute(new MiniClusterClient(miniCluster.getConfiguration(), miniCluster));

flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInFunctionTestBase.java:474

  • The method assertThatThrownBy should be updated to handle SerializedThrowable.
assertThatThrownBy(() -> tableResult.get().await())
@flinkbot
Copy link
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants