Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-7460] Relaxing compaction scheduling when there are pending delta commits #10791

Merged
merged 1 commit into from
May 14, 2024

Conversation

nsivabalan
Copy link
Contributor

Change Logs

Hudi has a constraint that compaction schedule can happen only if there are no pending delta commits whose instant time < compaction instant being scheduled. We were throwing exception when this condition is not met. Fixing the user behavior here so that we do not throw exception and return an empty plan when this condition is met.

Impact

This will smoothen our experience w/ async table service since the we don't have control over ingestion writer.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Mar 1, 2024
@nsivabalan nsivabalan force-pushed the compactionScheduleRelax branch from 0b087e4 to cd0426a Compare May 6, 2024 06:40
@jonvex jonvex self-assigned this May 9, 2024
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codope codope force-pushed the compactionScheduleRelax branch from cd0426a to 8c637d3 Compare May 14, 2024 13:53
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit 33e73d9 into apache:branch-0.x May 14, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-0.15.0 size:S PR with lines of changes in (10, 100] table-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants