[HUDI-8666] Revisit error message when timeline layout version cannot be read #12867
+42
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wombatu-kun
force-pushed
the
HUDI-8666_invalid_table_exception
branch
from
519ef99 to
805082f
Compare
wombatu-kun
force-pushed
the
HUDI-8666_invalid_table_exception
branch
2 times, most recently
from
16daa7a to
1371817
Compare
|
@hudi-bot run azure |
wombatu-kun
force-pushed
the
HUDI-8666_invalid_table_exception
branch
2 times, most recently
from
6ded773 to
7b8b533
Compare
wombatu-kun
force-pushed
the
HUDI-8666_invalid_table_exception
branch
from
7b8b533 to
b9f29f5
Compare
|
@hudi-bot run azure |
danny0405
reviewed
Feb 24, 2025
| @@ -149,7 +150,7 @@ public String createTable( | |||
| try { | |||
| HoodieTableMetaClient.builder().setConf(HoodieCLI.conf.newInstance()).setBasePath(path).build(); | |||
| existing = true; | |||
| } catch (TableNotFoundException dfe) { | |||
| } catch (TableNotFoundException | InvalidTableException dfe) { | |||
There was a problem hiding this comment.
The checked exception is hard to maintain in code, you don't expect developer to catch 2 checked exceptions every time initialing the meta client, no one can follow the rules. How about we just strengthen the error msgs first for the timeline layout.
As for the exception throwing, maybe we should switch to RuntimeException instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Changed exception class from
TableNotFoundExceptiontoInvalidTableException, made error message ofInvalidTableExceptionmore detailed.Impact
Exception type and error message are accurate.
Risk level (write none, low medium or high below)
none
Documentation Update
none
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist