Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: enable all linting checks and type-hint the code #14326

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

python: enable all linting checks and type-hint the code #14326

wants to merge 2 commits into from
+3,074 −2,845

Conversation

rmuir
Copy link
Member

@rmuir rmuir commented Mar 3, 2025

Review #14322 separate as it is included here to prevent merge conflicts.

So look at the 2nd commit if you want to see what has changed:

  • enable all type checking
  • type-hint the code to get checker flowing
  • disable a few remaining checks with a TODO list
  • enable all linter checks
  • autofix all safe fixes (e.g. api migrations)
  • disable just the remaining checks with a massive TODO list

rmuir added 2 commits March 2, 2025 14:11
@rmuir
reformat the python code with 'make reformat' and enable format in CI…
9ef6a26 
… check

currently the python code has a mix of indentation, styles, imports
ordering, etc. for example, it is very difficult to work with mixed
indentation levels: the language is sensitive to indentation.

reformat all the code with 'make reformat' and enable format checks when
linting. It works like spotless, just don't think about it.
@rmuir
python: enable all linting checks and type-hint the code
508d47a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rmuir