Eliminate some string operations

apache · Feb 23, 2025 · 9601fb0 · 9601fb0
1 parent 0912674
commit 9601fb0
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java b/enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java
@@ -161,18 +161,17 @@ private boolean match(String text, String pattern) {
     }
 
     private String populateErrorMessage(List<ArtifactRepository> resultBannedRepos, String errorMessagePrefix) {
-        StringBuffer errMsg = new StringBuffer("");
         if (!resultBannedRepos.isEmpty()) {
-            errMsg.append("Current maven session contains banned" + errorMessagePrefix
+            return "Current maven session contains banned" + errorMessagePrefix
                     + "repository urls, please double check your pom or settings.xml:" + System.lineSeparator()
-                    + getRepositoryUrlString(resultBannedRepos) + System.lineSeparator() + System.lineSeparator());
+                    + getRepositoryUrlString(resultBannedRepos) + System.lineSeparator() + System.lineSeparator();
         }
 
-        return errMsg.toString();
+        return "";
     }
 
     private String getRepositoryUrlString(List<ArtifactRepository> resultBannedRepos) {
-        StringBuilder urls = new StringBuilder("");
+        StringBuilder urls = new StringBuilder();
         for (ArtifactRepository repo : resultBannedRepos) {
             urls.append(repo.getId() + " - " + repo.getUrl() + System.lineSeparator());
         }