DefaultSftpClient can wait indefinitely in method send and init

[ecarou]

Version

2.8.0

Bug description

Using the DefaultSftpClient for transferring some files, i came accross an issue where the sftp client stop responding and do not close for several days.
Using a threadDump, i can see that the DefaultSftpClient is waiting indefinitely on the method send.
Got a similar issue several days after but this time in method init.

The server side is a very slow SFTP, and the connection is not stable but nevertheless, it should not block a thread forever.

Actual behavior

infinite wait can occur in method send and init of DefaultSftpClient because of this code :

IoWriteFuture writeFuture = asyncIn.writeBuffer(buf); writeFuture.verify();

the 2 methods are using verify without specifying a maximum wait time.

Expected behavior

If the other side doesn't answer in a predefined time, exit and free the ressource.

Relevant log output

Unfortunately i don't have the threadDump anymore.

Other information

occurs in version 2.8.0 (but will also appear in 2.9.2)

[lgoldstein]

Seems reasonable - I will look into it...

[lgoldstein]

Merged 60bbd7be