-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] PIP-192 Implemented ExtensibleLoadManagerWrapper.getLoadBalancingMetrics() #19440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
reviewed
Feb 7, 2023
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...roker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/models/SplitCounter.java
Show resolved
Hide resolved
...roker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/models/SplitCounter.java
Show resolved
Hide resolved
...roker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/data/BrokerLoadData.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #19440 +/- ##
============================================
+ Coverage 64.20% 64.34% +0.13%
- Complexity 26265 26409 +144
============================================
Files 1832 1836 +4
Lines 134067 134570 +503
Branches 14753 14816 +63
============================================
+ Hits 86077 86583 +506
- Misses 40135 40156 +21
+ Partials 7855 7831 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gaoran10
approved these changes
Feb 10, 2023
codelipenghui
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16691
Motivation
We will start raising PRs to implement PIP-192, #16691
Modifications
This PR implemented ExtensibleLoadManagerWrapper.getLoadBalancingMetrics()and its unit test.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
We will have separate PRs to update the Doc later.
Matching PR in forked repository
PR in forked repository: heesung-sn#28