Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-192 Added --extensions option in BrokerMonitor #19654

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

heesung-sn
Copy link
Contributor

@heesung-sn heesung-sn commented Feb 28, 2023

Master Issue: #16691

Motivation

Raising a PR to implement #16691.

Modifications

This PR

  • added --extensions option in BrokerMonitor in order to monitor BrokerLoadData in Load Balance Extension.

pulsar %  bin/pulsar-perf monitor-brokers --connect-string pulsar://localhost:6650 --extensions
2023-02-27T18:02:33,417-0800 [pulsar-client-io-1-3] INFO  org.apache.pulsar.client.impl.ConnectionPool - [[id: 0x330e1af9, L:/127.0.0.1:56972 - R:localhost/127.0.0.1:6650]] Connected to server
2023-02-27T18:02:33,551-0800 [pulsar-client-io-1-3] INFO  org.apache.pulsar.client.impl.ConsumerImpl - [non-persistent://pulsar/system/loadbalancer-broker-load-data][reader-617fc4e8f9] Subscribing to topic on cnx [id: 0x330e1af9, L:/127.0.0.1:56972 - R:localhost/127.0.0.1:6650], consumerId 0
2023-02-27T18:02:33,643-0800 [pulsar-client-io-1-3] INFO  org.apache.pulsar.client.impl.ConsumerImpl - [non-persistent://pulsar/system/loadbalancer-broker-load-data][reader-617fc4e8f9] Subscribed to topic on localhost/127.0.0.1:6650 -- consumer: 0
2023-02-27T18:11:33,718-0800 [main] INFO  org.apache.pulsar.testclient.BrokerMonitor -
Broker Data for localhost:8080:
===================================================================================================================
||SYSTEM         |CPU %          |MEMORY %       |DIRECT %       |BW IN %        |BW OUT %       |MAX %          ||
||               |17.24          |12.40          |26.95          |0.00           |0.00           |26.95          ||
||COUNT          |TOPIC          |BUNDLE         |PRODUCER       |CONSUMER       |BUNDLE +       |BUNDLE -       ||
||               |               |4              |               |               |               |               ||
||LATEST         |MSG/S IN       |MSG/S OUT      |TOTAL          |KB/S IN        |KB/S OUT       |TOTAL          ||
||               |100.02         |0.02           |100.03         |103.89         |0.01           |103.90         ||
===================================================================================================================

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • *Updated unit tests.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

We will have separate PRs to update the Doc later.

Matching PR in forked repository

PR in forked repository: heesung-sn#34

@Technoboy- Technoboy- added this to the 3.0.0 milestone Feb 28, 2023
@Technoboy- Technoboy- added type/feature The PR added a new feature or issue requested a new feature ready-to-test labels Feb 28, 2023
@Technoboy- Technoboy- closed this Feb 28, 2023
@Technoboy- Technoboy- reopened this Feb 28, 2023
@Technoboy- Technoboy- merged commit 579f22c into apache:master Mar 1, 2023
@heesung-sn heesung-sn deleted the pip-192-broker-monitor branch April 2, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants