-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] PIP-192: Filter the transfer dest broker #19958
Merged
Technoboy-
merged 3 commits into
apache:master
from
Demogorgon314:Demogorgon314/PIP-192-filter-dest-broker
Apr 5, 2023
Merged
[improve][broker] PIP-192: Filter the transfer dest broker #19958
Technoboy-
merged 3 commits into
apache:master
from
Demogorgon314:Demogorgon314/PIP-192-filter-dest-broker
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f2a551
to
abee92c
Compare
heesung-sn
approved these changes
Mar 31, 2023
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/scheduler/TransferShedder.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #19958 +/- ##
============================================
- Coverage 72.88% 72.80% -0.08%
+ Complexity 31616 31576 -40
============================================
Files 1861 1861
Lines 137356 137353 -3
Branches 15117 15115 -2
============================================
- Hits 100111 100000 -111
- Misses 29291 29385 +94
- Partials 7954 7968 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@gaoran10 @Technoboy- PTAL by any chance. |
Technoboy-
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
doc-not-needed
Your PR changes do not impact docs
ready-to-test
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #16691
Motivation
The PIP-192 introduced transfer to transfer the bundle from ower broker to a specific broker without unloading,
But the dest broker is not filtered by the broker filter.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete