-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] PIP-192 made split handler idempotent #19988
[improve][broker] PIP-192 made split handler idempotent #19988
Conversation
0f681d9
to
287b79f
Compare
targetNsBundle.validateBundle(parentBundle); | ||
} catch (IllegalArgumentException e) { | ||
if (debug) { | ||
log.info("Namespace bundles do not contain the parent bundle:{}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If namespace bundles do not contain the parent bundle, we shouldn't continue to verify the child bundles, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If namespace bundles do not contain the parent bundle, this means the namespace bundles must have child bundles(the namespace policy must have been updated). Here, we redundantly verify if the child bundles are there. If there is no parent bundle, and if there are no child bundles, the current logic will retry forever. I can't think of a case that the current logics lead to this state, but in the worst case, the error count of the split metrics should constantly increase, expecting the admins to unload this parent bundle.
e3b361b
to
9a6708d
Compare
@Demogorgon314 @gaoran10 PLAL by any chance. |
@Demogorgon314 @Technoboy- PTAL by any chance. |
@Demogorgon314 fyi, I updated the code
|
a7000c5
to
c4562ca
Compare
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Show resolved
Hide resolved
/pulsarbot rerun-failure-checks |
@Demogorgon314 @Technoboy- plz merge if looking good |
Master Issue: #16691
Motivation
Raising a PR to implement: #16691
Modifications
This PR
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
We will have separate PRs to update the Doc later.
Matching PR in forked repository
PR in forked repository: heesung-sn#41