[fix][broker] Handle heartbeat namespace in ExtensibleLoadManager #20551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
added
type/bug
Demogorgon314
force-pushed
the
Demogorgon314/handle_heartbeat_namespace
branch
from
115ca33 to
7aa18bd
Compare
heesung-sn
approved these changes
Jun 9, 2023
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
mattisonchao
approved these changes
Jun 12, 2023
Technoboy-
reviewed
Jun 12, 2023
| } | ||
| return CompletableFuture.completedFuture(brokerLookupData); | ||
| })); | ||
| private CompletableFuture<Optional<BrokerLookupData>> getBrokerLookupData( |
There was a problem hiding this comment.
yes, the same idea with @mattisonchao
There was a problem hiding this comment.
The serviceUnitStateChannel.getChannelOwnerAsync() will return Optional, so we can change this method.
Demogorgon314
force-pushed
the
Demogorgon314/handle_heartbeat_namespace
branch
from
a213c69 to
972d640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #16691
Motivation
The heartbeat namespace bundle requires acquiring ownership when broker starts,
however, the
ExtensibleLoadManagerdoes not handle this case,we should register the heartbeat namespace to let the health check work.
Modifications
tryAcquiringOwnershipmethod to acquire the local broker ownershipDocumentation
docdoc-requireddoc-not-neededdoc-complete