[SPARK-51290][SQL] Enable filling default values in DSv2 writes #50044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
commented
Feb 21, 2025
| @@ -3534,7 +3534,8 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor | |||
| TableOutputResolver.suitableForByNameCheck(v2Write.isByName, | |||
| expected = v2Write.table.output, queryOutput = v2Write.query.output) | |||
| val projection = TableOutputResolver.resolveOutputColumns( | |||
| v2Write.table.name, v2Write.table.output, v2Write.query, v2Write.isByName, conf) | |||
| v2Write.table.name, v2Write.table.output, v2Write.query, v2Write.isByName, conf, | |||
| supportColDefaultValue = true) | |||
There was a problem hiding this comment.
I don't think there is value in validating if the catalog defines SUPPORT_COLUMN_DEFAULT_VALUE in capabilities during writes. If a connector includes default value metadata in its schema, it should be enough to fill default values. The flag exists for ALTER and CREATE/REPLACE statements.
aokolnychyi
commented
Feb 21, 2025
| @@ -718,6 +724,11 @@ private class BufferedRowsReader( | |||
| schema: StructType, | |||
| row: InternalRow): Any = { | |||
| val index = schema.fieldIndex(field.name) | |||
|
|
|||
| if (index >= row.numFields) { | |||
There was a problem hiding this comment.
This is needed for support for adding columns with default values to the end.
aokolnychyi
commented
Feb 21, 2025
| @@ -423,8 +423,8 @@ abstract class V2WriteAnalysisSuiteBase extends AnalysisTest { | |||
| assertNotResolved(parsedPlan) | |||
| assertAnalysisErrorCondition( | |||
| parsedPlan, | |||
| expectedErrorCondition = "INCOMPATIBLE_DATA_FOR_TABLE.CANNOT_FIND_DATA", | |||
| expectedMessageParameters = Map("tableName" -> "`table-name`", "colName" -> "`x`") | |||
| expectedErrorCondition = "INCOMPATIBLE_DATA_FOR_TABLE.EXTRA_COLUMNS", | |||
There was a problem hiding this comment.
This is because of spark.sql.defaultColumn.useNullsForMissingDefaultValues and is aligned with V1 writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enables filling default values in DSv2 writes.
Why are the changes needed?
These changes are needed for proper support of default values for DSv2 connectors.
Does this PR introduce any user-facing change?
Users will be able to omit columns with default values. There is no impact to existing jobs.
How was this patch tested?
This patch comes with tests.
Was this patch authored or co-authored using generative AI tooling?
No.