TOMEE-4424 - improved JAX-RS request matching if a welcome-file is defined

[jungm]

See https://issues.apache.org/jira/browse/TOMEE-4424

Fulll build is running: https://ci-builds.apache.org/job/Tomee/view/tomee-10.x/job/pull-request-manual/146/

[rzo1]

I triggered a rebuild (but the failing tests might be actual regression, so just to be sure). Can you do a JAX-RS TCK run as well?

[jungm]

Ran the JAX-RS TCK now:

[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   JAXRSClientIT.getMediaTypeTest:129->ReaderClient.invoke:84 » Fault jakarta.ws.rs.client.ResponseProcessingException: Problem with reading the data, class java.lang.String, ContentType: application/json.
[ERROR]   JAXRSClientIT.getMediaTypeTest:149->WriterClient.invoke:57 » Fault ee.jakarta.tck.ws.rs.common.JAXRSCommonClient$Fault: [JAXRSCommonClient] null failed!  Check output for cause of failure.
[ERROR]   JAXRSClientIT.getMediaTypeTest:180->ReaderClient.invoke:50->ReaderClient.invoke:64 » Fault ee.jakarta.tck.ws.rs.common.JAXRSCommonClient$Fault: [JAXRSCommonClient] null failed!  Check output for cause of failure.
[ERROR]   JAXRSClientIT.getMediaTypeTest:140->WriterClient.invoke:39->JaxrsCommonClient.invoke:209 » ResponseProcessing Problem with reading the data, class java.lang.String, ContentType: application/json.
[ERROR]   JAXRSClientIT.invocationFromLinkApplicationJsonMediaTypeTest:154->checkResposeForMessage:194 » ResponseProcessing Problem with reading the data, class java.lang.String, ContentType: application/json.
[ERROR]   JAXRSClientIT.byteArrayProviderTest:172->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed!  Check output for cause of failure.
[ERROR]   JAXRSClientIT.dataSourceProviderTest:260->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed!  Check output for cause of failure.
[ERROR]   JAXRSClientIT.fileProviderTest:243->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed!  Check output for cause of failure.
[ERROR]   JAXRSClientIT.inputStreamProviderTest:206->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed!  Check output for cause of failure.
[ERROR]   JAXRSClientIT.readerProviderTest:226->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed!  Check output for cause of failure.
[ERROR]   JAXRSClientIT.streamingOutputProviderTest:295->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed!  Check output for cause of failure.
[ERROR]   JAXRSClientIT.stringProviderTest:189->setEntityAndPropertyAndInvoke:73->setPropertyAndInvoke:66->JAXRSCommonClient.invoke:328 » Fault [JAXRSCommonClient] null failed!  Check output for cause of failure.
[INFO] 
[ERROR] Tests run: 2785, Failures: 0, Errors: 12, Skipped: 132

This did definitely break something, I'll look at this

[jungm]

Looks like the same tests are failing on main now too (see full build and tck), I suspect that a change in CXF is causing these failures. Will keep this as a draft until these are resolved

[rzo1]

Let's see if the adaptions in https://github.com/apache/tomee/tree/cxf-4.1.x-jsonp-fixes will fix the TCK/build on the manual full build, so we get it sorted out.

[rzo1]

So let's see how it goes https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/153/

[jungm]

the 2 failing tests are unrelated, see 9a68d9f