[AOT] Remove lookup parameter function in AOT #7988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areusch
reviewed
May 6, 2021
tqchen
changed the title
added 2 commits
May 18, 2021 22:50
This PR aims at removing the function call to extract the parameters within the AOT main function by introducing a tir::lookup_param builtin. This has different benefits: - In AOT we now only use the v_handle field - We save cycles by not calling an intermediate function to extract local parameters - We reduce code size, since we don't need to pack a call to extract parameters and we don't need to produce the lookup_param function anymore within the compilation unit Change-Id: I36c2f0724a79606424a4374f4f5cd669bb2a8a55
Change-Id: I83ba0189f559d310b5a80fe0bcc4d601b490d21a
giuseros
force-pushed
the
aot-remove-call-params
branch
from
3692704 to
c7109ca
Compare
|
Hi @areusch sorry for the delayed reply. Somehow my github notifications were not working properly. |
Change-Id: I84ab4a526d1284ded41fe95636e94c15412f6b28
areusch
approved these changes
May 20, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 17, 2021
* AOT] Remove lookup parameter function in AOT This PR aims at removing the function call to extract the parameters within the AOT main function by introducing a tir::lookup_param builtin. This has different benefits: - In AOT we now only use the v_handle field - We save cycles by not calling an intermediate function to extract local parameters - We reduce code size, since we don't need to pack a call to extract parameters and we don't need to produce the lookup_param function anymore within the compilation unit Change-Id: I36c2f0724a79606424a4374f4f5cd669bb2a8a55 * addressing comments Change-Id: I83ba0189f559d310b5a80fe0bcc4d601b490d21a * retrigger CI Change-Id: I84ab4a526d1284ded41fe95636e94c15412f6b28
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 17, 2021
* AOT] Remove lookup parameter function in AOT This PR aims at removing the function call to extract the parameters within the AOT main function by introducing a tir::lookup_param builtin. This has different benefits: - In AOT we now only use the v_handle field - We save cycles by not calling an intermediate function to extract local parameters - We reduce code size, since we don't need to pack a call to extract parameters and we don't need to produce the lookup_param function anymore within the compilation unit Change-Id: I36c2f0724a79606424a4374f4f5cd669bb2a8a55 * addressing comments Change-Id: I83ba0189f559d310b5a80fe0bcc4d601b490d21a * retrigger CI Change-Id: I84ab4a526d1284ded41fe95636e94c15412f6b28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at removing the function call to extract the parameters
within the AOT main function by introducing a
tir::lookup_parambuiltin.This has different benefits:
v_handlefield of theTVMValuestructlocal parameters
parameters and we don't need to produce the
lookup_paramfunctionanymore within the compilation unit
Change-Id: I36c2f0724a79606424a4374f4f5cd669bb2a8a55