Composer updated for Drupal 11 readiness #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedarkhaire
requested review from
giteshk,
shishir-intelli and
divya-intelli
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## drupal11-prep #507 +/- ##
================================================
Coverage ? 49.10%
Complexity ? 2001
================================================
Files ? 200
Lines ? 7407
Branches ? 0
================================================
Hits ? 3637
Misses ? 3770
Partials ? 0 |
kedarkhaire
force-pushed
the
issue-504
branch
from
4e40c2a to
ec33c93
Compare
composer.json
Outdated
| "drupal/core": "^10.3 || ^11.1", | ||
| "drupal/requirement": "dev-issue-007", | ||
| "drupal/jquery_ui_dialog": "^2.1", | ||
| "drupal/commerce": "^3.0", |
There was a problem hiding this comment.
Do we need to add here?
There was a problem hiding this comment.
Yes, with the inner dependencies, it is not picking to install
We have jquery_ui_dialog, requirement modules defined inside along with commerce, still they are defined here.
Also in edge, we have defined keys and others in dependencies as well as in require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504