add ability to choose sort order #19
Conversation
* replace querySelector with getElementById because it can handle ids that start with numbers * add functionality to sort by date asc or desc
|
Will fix merge conflicts tomorrow |
aplotor
changed the title
|
ive added contributing guidelines to the repo. please read before continuing |
| <label class="btn btn-secondary shadow-none"><input type="radio" name="options"/>posts</label> | ||
| <label class="btn btn-secondary shadow-none"><input type="radio" name="options"/>comments</label> | ||
| <label class="btn btn-secondary shadow-none active"><input type="radio" name="options"/>all</label> | ||
| </div> | ||
| <div bind:this={sort_btn_group} class="btn_padded btn-group btn-group-toggle flex-wrap" data-toggle="buttons"> |
There was a problem hiding this comment.
i see youve added a btn group. i think it would be a better design to simply have a small toggle btn with visual indicator (e.g., unpressed for desc, pressed for asc) for this sort feature, rather than a whole new btn group, to avoid bloating up the ui
ideal position for it
(the btn should visually fit with that row. the size of the subreddit select should be decreased to make space for it, and there should be spacing between the subreddit select and the new btn, like the search bar and the subreddit select)
There was a problem hiding this comment.
Will try to implement this, might take a bit since I'm unfamiliar with svelte and JS
| @@ -185,6 +185,12 @@ img { | |||
| list-style-type: none; | |||
| } | |||
|
|
|||
| .btn_padded { | |||
There was a problem hiding this comment.
use inline bootstrap margin shorthand to adhere with the existing convention rather than creating a new css class
Add new sort by date ascending/descending capability
(contains fix for bug(s) as well)