Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust long polling timeout #1003

Merged

Conversation

nobodyiam
Copy link
Member

  1. adjust server side's long polling timeout from 30 seconds to 60 seconds
  2. adjust client side's long polling timeout from 600 seconds to 90 seconds

…conds

2. adjust client side's long polling timeout from 600 seconds to 90 seconds
@codecov-io
Copy link

codecov-io commented Mar 17, 2018

Codecov Report

Merging #1003 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1003      +/-   ##
============================================
- Coverage     48.64%   48.63%   -0.01%     
+ Complexity     1671     1670       -1     
============================================
  Files           364      364              
  Lines         10144    10144              
  Branches       1026     1026              
============================================
- Hits           4935     4934       -1     
  Misses         4847     4847              
- Partials        362      363       +1
Impacted Files Coverage Δ Complexity Δ
...o/configservice/wrapper/DeferredResultWrapper.java 100% <ø> (ø) 12 <0> (ø) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.3% <100%> (-0.62%) 27 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ee12c...bbdf8e5. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.218% when pulling bbdf8e5 on nobodyiam:adjust-long-polling-timeout into 92ee12c on ctripcorp:master.

@nobodyiam nobodyiam merged commit 2f23140 into apolloconfig:master Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants