Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto update not triggered issue #1013

Merged

Conversation

nobodyiam
Copy link
Member

fix the auto update not triggered issue when there are same keys in different namespaces and the one with high priority deleted.

…rent namespaces and the one with high priority deleted
@codecov-io
Copy link

codecov-io commented Mar 24, 2018

Codecov Report

Merging #1013 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1013      +/-   ##
============================================
+ Coverage     48.62%   48.63%   +<.01%     
- Complexity     1672     1673       +1     
============================================
  Files           364      364              
  Lines         10144    10147       +3     
  Branches       1026     1027       +1     
============================================
+ Hits           4933     4935       +2     
  Misses         4849     4849              
- Partials        362      363       +1
Impacted Files Coverage Δ Complexity Δ
...pring/property/AutoUpdateConfigChangeListener.java 91.22% <100%> (+0.48%) 16 <2> (+2) ⬆️
...ervice/service/ReleaseMessageServiceWithCache.java 85.71% <0%> (-1.2%) 24% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ffa3bf...6267020. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 52.212% when pulling 6267020 on nobodyiam:fix-auto-update-with-deleted-keys into 8ffa3bf on ctripcorp:master.

@nobodyiam nobodyiam merged commit 4d8ce1a into apolloconfig:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants