Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert to eureka client implementation to get the correct home page url #3176

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

revert to eureka client implementation to get the correct home page url

Which issue(s) this PR fixes:

Fixes #3165

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2020

Codecov Report

Merging #3176 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3176      +/-   ##
============================================
- Coverage     51.55%   51.53%   -0.02%     
  Complexity     2253     2253              
============================================
  Files           433      433              
  Lines         13451    13447       -4     
  Branches       1379     1378       -1     
============================================
- Hits           6934     6930       -4     
  Misses         6037     6037              
  Partials        480      480              
Impacted Files Coverage Δ Complexity Δ
...o/metaservice/service/DefaultDiscoveryService.java 100.00% <100.00%> (ø) 6.00 <5.00> (ø)
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) 20.00% <0.00%> (-1.00%)
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) 25.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b3f6f...8604965. Read the comment docs.

@nobodyiam nobodyiam merged commit 5e0ab3c into apolloconfig:master Jul 11, 2020
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EUREKA_INSTANCE_HOME_PAGE_URL环境变量无效
2 participants