Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish some code #3249

Merged
merged 2 commits into from
Aug 22, 2020
Merged

polish some code #3249

merged 2 commits into from
Aug 22, 2020

Conversation

JaredTan95
Copy link
Member

What's the purpose of this PR

polish some gson code.

@JaredTan95 JaredTan95 requested a review from nobodyiam August 18, 2020 09:24
@JaredTan95 JaredTan95 added this to the 1.8.0 milestone Aug 18, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #3249 into master will increase coverage by 0.01%.
The diff coverage is 74.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3249      +/-   ##
============================================
+ Coverage     51.47%   51.48%   +0.01%     
- Complexity     2294     2304      +10     
============================================
  Files           442      442              
  Lines         13739    13733       -6     
  Branches       1398     1397       -1     
============================================
- Hits           7072     7071       -1     
+ Misses         6176     6173       -3     
+ Partials        491      489       -2     
Impacted Files Coverage Δ Complexity Δ
...trip/framework/apollo/biz/service/ItemService.java 15.06% <0.00%> (+0.40%) 4.00 <0.00> (ø)
...ramework/apollo/openapi/util/OpenApiBeanUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (ø) 5.00 <0.00> (ø)
...mework/apollo/portal/spi/ctrip/CtripMQService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ramework/apollo/portal/service/ReleaseService.java 5.61% <25.00%> (ø) 2.00 <1.00> (ø)
...k/apollo/portal/component/config/PortalConfig.java 22.82% <33.33%> (ø) 9.00 <0.00> (ø)
...inservice/controller/ReleaseHistoryController.java 25.00% <50.00%> (ø) 2.00 <1.00> (+1.00)
...m/ctrip/framework/apollo/biz/config/BizConfig.java 26.78% <50.00%> (ø) 8.00 <1.00> (ø)
...p/framework/apollo/portal/service/ItemService.java 47.87% <50.00%> (ø) 17.00 <1.00> (+1.00)
...k/apollo/portal/service/ReleaseHistoryService.java 7.46% <50.00%> (ø) 2.00 <1.00> (+1.00)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff6ddd...558b843. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 077b176 into master Aug 22, 2020
@kezhenxu94 kezhenxu94 deleted the optim_code branch August 22, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants