Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ingress support for config service and admin service #3324

Merged

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Oct 2, 2020

What's the purpose of this PR

add ingress support for config service and admin service

Which issue(s) this PR fixes:

Fixes #3316

Brief changelog

  1. add context path and ingress support for config service and admin service
  2. allow users to override image tags

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@nobodyiam nobodyiam force-pushed the ingress-support-for-apollo-service branch from e1581a4 to 53231aa Compare October 3, 2020 10:37
@nobodyiam nobodyiam marked this pull request as ready for review October 3, 2020 10:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #3324 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3324      +/-   ##
============================================
+ Coverage     51.35%   51.49%   +0.14%     
- Complexity     2301     2306       +5     
============================================
  Files           442      442              
  Lines         13738    13738              
  Branches       1398     1398              
============================================
+ Hits           7055     7075      +20     
+ Misses         6192     6175      -17     
+ Partials        491      488       -3     
Impacted Files Coverage Δ Complexity Δ
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) 21.00% <0.00%> (+1.00%)
...ework/apollo/internals/RemoteConfigRepository.java 89.37% <0.00%> (+3.12%) 25.00% <0.00%> (+1.00%)
...rk/apollo/spring/property/SpringValueRegistry.java 88.88% <0.00%> (+5.55%) 11.00% <0.00%> (+1.00%)
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) 5.00% <0.00%> (ø%)
...work/apollo/biz/message/DatabaseMessageSender.java 64.58% <0.00%> (+14.58%) 8.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ccf39...5f62b13. Read the comment docs.

…service

2. allow users to override image tags
@nobodyiam nobodyiam force-pushed the ingress-support-for-apollo-service branch from 97d34c5 to 5f62b13 Compare October 3, 2020 10:53
@nobodyiam nobodyiam merged commit 33fbda3 into apolloconfig:master Oct 3, 2020
@sheng-jie
Copy link

When will this change be published to the latest helm chart package?

@nobodyiam
Copy link
Member Author

@sheng-jie It shall be released with apollo 1.8.0, which is planned to happen in late Feb.

@nobodyiam nobodyiam added this to the 1.8.0 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8S部署,configservice配置使用ingress转发,密钥校验失败
3 participants