Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: modify item comment valid size(#3799) #3803

Merged
merged 4 commits into from
Jul 3, 2021

Conversation

chengasd
Copy link
Contributor

@chengasd chengasd commented Jul 2, 2021

What's the purpose of this PR

修改openapi创建item校验的comment长度大小,兼容历史业务场景升级。

Which issue(s) this PR fixes:

Fixes #3799

Brief changelog

1、openapi入口ItemController.java comment校验长度大小改为256
2、portal前端入口valdr.js comment长度大小同步改为256
3、en.json 、zh-CN.json 修改对应数值

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nobodyiam
Copy link
Member

Comment length 1024 might be a little big, I noticed the comment length limit for release is 256 in the database, how about we increase both limits to 256 first?

@chengasd
Copy link
Contributor Author

chengasd commented Jul 3, 2021

Comment length 1024 might be a little big, I noticed the comment length limit for release is 256 in the database, how about we increase both limits to 256 first?

ok , It's done

@codecov-commenter
Copy link

Codecov Report

Merging #3803 (03c59fb) into master (39aa560) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3803   +/-   ##
=========================================
  Coverage     50.13%   50.13%           
- Complexity     2443     2444    +1     
=========================================
  Files           479      479           
  Lines         14807    14807           
  Branches       1503     1503           
=========================================
+ Hits           7423     7424    +1     
  Misses         6860     6860           
+ Partials        524      523    -1     
Impacted Files Coverage Δ
...k/apollo/openapi/v1/controller/ItemController.java 8.16% <0.00%> (ø)
...work/apollo/biz/message/ReleaseMessageScanner.java 73.33% <0.00%> (-4.45%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39aa560...03c59fb. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 1afa5ad into apolloconfig:master Jul 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

升级至1.8.2后调用openapi接口comment长度校验问题
3 participants