-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: modify item comment valid size(#3799) #3803
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Comment length 1024 might be a little big, I noticed the comment length limit for release is 256 in the database, how about we increase both limits to 256 first? |
ok , It's done |
Codecov Report
@@ Coverage Diff @@
## master #3803 +/- ##
=========================================
Coverage 50.13% 50.13%
- Complexity 2443 2444 +1
=========================================
Files 479 479
Lines 14807 14807
Branches 1503 1503
=========================================
+ Hits 7423 7424 +1
Misses 6860 6860
+ Partials 524 523 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
修改openapi创建item校验的comment长度大小,兼容历史业务场景升级。
Which issue(s) this PR fixes:
Fixes #3799
Brief changelog
1、openapi入口ItemController.java comment校验长度大小改为256
2、portal前端入口valdr.js comment长度大小同步改为256
3、en.json 、zh-CN.json 修改对应数值
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.