Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deployment): use flowchart to illustrate deployment architecture in different scenes #4017

Merged
merged 23 commits into from
Oct 17, 2021

Conversation

Anilople
Copy link
Contributor

@Anilople Anilople commented Oct 7, 2021

What's the purpose of this PR

Add more document.

Use flowchart to illustrate deployment architecture in different scenes

Which issue(s) this PR fixes:

None

Brief changelog

  • Add a new link to sidebar.
  • Create 2 new markdown files deployment-architecture.md.

An example of flowchart

image

More flowchart in https://anilople.github.io/apollo/#/zh/deployment/deployment-architecture

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@Anilople Anilople added the area/document Category issues or prs related to document. label Oct 7, 2021

1个环境只有1个Config Service进程,无法满足高可用,为了避免单点宕机后影响系统的可用性,需要多实例部署,也就是部署多个Java进程在不同的Linux服务器上

TODO
Copy link
Contributor Author

@Anilople Anilople Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will done soon or left to another pull request.

@Anilople Anilople marked this pull request as ready for review October 7, 2021 11:54
@Anilople
Copy link
Contributor Author

Anilople commented Oct 7, 2021

Is it reasonable to put the deployment architecture document here? Or move to another place?

@nobodyiam
Copy link
Member

Is it reasonable to put the deployment architecture document here? Or move to another place?

Is it better to put it in Distributed Deployment Guide - 1.3 Environment section?
Or if it is too long to be put there, then we could have a link to this document?

@codecov-commenter
Copy link

Codecov Report

Merging #4017 (127fa0a) into master (8484178) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4017      +/-   ##
============================================
+ Coverage     51.46%   51.49%   +0.03%     
- Complexity     2524     2531       +7     
============================================
  Files           484      484              
  Lines         14798    14839      +41     
  Branches       1532     1537       +5     
============================================
+ Hits           7616     7642      +26     
- Misses         6652     6666      +14     
- Partials        530      531       +1     
Impacted Files Coverage Δ
...work/apollo/biz/message/DatabaseMessageSender.java 50.00% <0.00%> (-14.59%) ⬇️
...internals/provider/DefaultApplicationProvider.java 49.16% <0.00%> (-2.84%) ⬇️
...ework/apollo/internals/RemoteConfigRepository.java 88.34% <0.00%> (-1.04%) ⬇️
...ramework/apollo/openapi/util/OpenApiBeanUtils.java 8.82% <0.00%> (-0.14%) ⬇️
...work/apollo/common/dto/GrayReleaseRuleItemDTO.java 0.00% <0.00%> (ø)
...rk/foundation/internals/provider/NullProvider.java 0.00% <0.00%> (ø)
...apollo/openapi/dto/OpenGrayReleaseRuleItemDTO.java 0.00% <0.00%> (ø)
...ring/boot/ApolloApplicationContextInitializer.java 94.33% <0.00%> (ø)
...llo/configservice/controller/ConfigController.java 95.29% <0.00%> (ø)
...configservice/controller/ConfigFileController.java 83.47% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8484178...127fa0a. Read the comment docs.

@Anilople Anilople requested a review from nobodyiam October 16, 2021 07:12
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 98f7c8b into apolloconfig:master Oct 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/document Category issues or prs related to document.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants