Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:occur a 400 error request when openapi key's parameter contain "a[0]" #4424

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

CalebZYC
Copy link
Contributor

What's the purpose of this PR

fix:occur a 400 error request when openapi key's parameter contain "a[0]"

Which issue(s) this PR fixes:

Fixes #4422

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@CalebZYC CalebZYC changed the title fix:occur a 400 error request when openapi key's parameter contain "a… fix:occur a 400 error request when openapi key's parameter contain "a[0]" Jun 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #4424 (e1066b7) into master (b73204a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4424      +/-   ##
============================================
+ Coverage     53.34%   53.38%   +0.04%     
- Complexity     2683     2684       +1     
============================================
  Files           490      490              
  Lines         15245    15254       +9     
  Branches       1586     1586              
============================================
+ Hits           8132     8143      +11     
+ Misses         6555     6553       -2     
  Partials        558      558              
Impacted Files Coverage Δ
.../framework/apollo/openapi/PortalOpenApiConfig.java 100.00% <100.00%> (ø)
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (-4.69%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...ework/apollo/internals/RemoteConfigRepository.java 87.73% <0.00%> (+2.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73204a...e1066b7. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 7d25d55 into apolloconfig:master Jun 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2022
@CalebZYC CalebZYC deleted the issue-4422 branch September 19, 2022 14:39
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openapi请求如果key有[],则报400错误
3 participants