Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin can modify app information #542

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Feb 14, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 49.628% when pulling c9cd22e on lepdou:modify_app_info into f5373b1 on ctripcorp:master.

@codecov-io
Copy link

codecov-io commented Feb 14, 2017

Codecov Report

Merging #542 into master will decrease coverage by -0.2%.
The diff coverage is 18.18%.

@@             Coverage Diff             @@
##             master     #542     +/-   ##
===========================================
- Coverage     46.47%   46.27%   -0.2%     
- Complexity     1302     1307      +5     
===========================================
  Files           310      312      +2     
  Lines          8420     8469     +49     
  Branches        810      814      +4     
===========================================
+ Hits           3913     3919      +6     
- Misses         4222     4267     +45     
+ Partials        285      283      -2
Impacted Files Coverage Δ Complexity Δ
.../apollo/adminservice/controller/AppController.java 79.31% <ø> (-12.69%) 10 <ø> (ø)
...ip/framework/apollo/portal/service/AppService.java 1.88% <ø> (-2.66%) 1 <ø> (ø)
...p/framework/apollo/portal/api/AdminServiceAPI.java 15.44% <ø> (-0.24%) 1 <ø> (ø)
...ework/apollo/portal/listener/CreationListener.java 9.09% <ø> (ø) 2 <ø> (ø)
...k/apollo/portal/component/PermissionValidator.java 6.25% <ø> (-0.42%) 1 <ø> (ø)
...ctrip/framework/apollo/biz/service/AppService.java 27.77% <ø> (-7.94%) 4 <ø> (ø)
...rk/apollo/portal/listener/AppInfoChangedEvent.java 0% <ø> (ø) 0 <ø> (?)
...apollo/portal/listener/AppInfoChangedListener.java 15.38% <15.38%> (ø) 2 <2> (?)
...mework/apollo/portal/controller/AppController.java 23.07% <45.16%> (+0.26%) 3 <2> (+1)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5373b1...8a39cce. Read the comment docs.

@lepdou lepdou force-pushed the modify_app_info branch 2 times, most recently from a83f7c6 to 933bfad Compare February 14, 2017 09:58
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 49.628% when pulling 933bfadc40d3f94984b39443d96d282baf234de7 on lepdou:modify_app_info into f5373b1 on ctripcorp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 49.628% when pulling 933bfadc40d3f94984b39443d96d282baf234de7 on lepdou:modify_app_info into f5373b1 on ctripcorp:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 49.628% when pulling 8a39cce on lepdou:modify_app_info into f5373b1 on ctripcorp:master.

@nobodyiam nobodyiam merged commit 87129ad into apolloconfig:master Feb 14, 2017
@lepdou lepdou deleted the modify_app_info branch February 16, 2017 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants