Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix for Spring #560

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Conversation

nobodyiam
Copy link
Member

  1. make ApolloAnnotationProcessor run as late as possible
  2. make PropertySourcesProcessor run as early as possible
  3. fix PropertySourcesProcessor initialization logic to support multple
    Spring contexts

1. make ApolloAnnotationProcessor run as late as possible
2. make PropertySourcesProcessor run as early as possible
3. fix PropertySourcesProcessor initialization logic to support multple
Spring contexts
@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.698% when pulling 9b06053 on nobodyiam:apollo-spring-fix into 6f30d52 on ctripcorp:master.

@codecov-io
Copy link

Codecov Report

Merging #560 into master will decrease coverage by -0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #560      +/-   ##
============================================
- Coverage     46.34%   46.33%   -0.02%     
- Complexity     1360     1361       +1     
============================================
  Files           325      325              
  Lines          8779     8779              
  Branches        841      841              
============================================
- Hits           4069     4068       -1     
  Misses         4417     4417              
- Partials        293      294       +1
Impacted Files Coverage Δ Complexity Δ
...o/spring/annotation/ApolloAnnotationProcessor.java 100% <100%> (ø) 12 <2> (+1)
...apollo/spring/config/PropertySourcesProcessor.java 100% <100%> (ø) 11 <6> (+1)
...ervice/service/ReleaseMessageServiceWithCache.java 85.71% <0%> (-1.2%) 24% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f30d52...9b06053. Read the comment docs.

@lepdou lepdou merged commit 75878e1 into apolloconfig:master Mar 8, 2017
@nobodyiam nobodyiam deleted the apollo-spring-fix branch April 8, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants