Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge #934 #1041

Merged
merged 5 commits into from
Jan 5, 2017
Merged

Merge #934 #1041

merged 5 commits into from
Jan 5, 2017

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Dec 14, 2016

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@stubailo
Copy link
Contributor Author

OK I have learned that merging this needs to coordinate with merging basically every other PR to switch to @types/graphql at the exact same time, so we shouldn't do it while @helfer is out.

@intellix
Copy link
Contributor

LGTM. I guess I missed a few after the rebase :) Thanks

@helfer
Copy link
Contributor

helfer commented Dec 16, 2016

This is going to be fun 👷

@intellix intellix mentioned this pull request Jan 3, 2017
4 tasks
@helfer helfer merged commit 9bd6a01 into master Jan 5, 2017
@helfer helfer deleted the merge-934 branch January 5, 2017 01:55
@helfer helfer removed the in progress label Jan 5, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants