-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the submission message of apostrophe-moderator #169
Comments
Your friend Danny wrote the i18n support (: You should talk to him about The message probably needs to come from the server in some way, we really On Tue, Oct 28, 2014 at 5:10 AM, Danny Braunstein [email protected]
*THOMAS BOUTELL, *DEV & OPS |
Hm alright, but for now how can I override this alert ? |
Right now, you can't. That needs fixing. Talk to Danny about how to make it On Tue, Oct 28, 2014 at 8:46 AM, Danny Braunstein [email protected]
*THOMAS BOUTELL, *DEV & OPS |
i18n for strings pushed to the frontend was a bit tricky since there wasn't a united mechanism to how they end up in the frontend. I think I tried to push as many as possible, but it's somewhat a mess. I'll look into it with @Danny-weebo |
Hi @Danny-weebo, We don't have great support for apostrophe-moderator, but you can change this line if you overwrite the Please create a ticket in that module for this feature, and feel free to submit a PR with code that allows for this to the apostrophe-moderator module. |
Thanks Ben. Just to clarify, apostrophe-moderator is fully supported. We should start pushing a dictionary of i18n strings JavaScript needs into For now we could just move the string to a configuration option so you can Reopening because this is unresolved and we are using it in our own
|
Hey @boutell am, I correct in seeing that these messages can now be overridden here https://github.com/punkave/apostrophe-moderator#overriding-methods (haven't gotten all the way to testing but it looks like what this issue is after) |
Yes, also it's 0.5 and in maintenance mode. Closing.
…On Mon, Jun 19, 2017 at 10:41 AM, Stuart Romanek ***@***.***> wrote:
Hey @boutell <https://github.com/boutell> am, I correct in seeing that
these messages can now be overridden here https://github.com/punkave/
apostrophe-moderator#overriding-methods
(haven't gotten all the way to testing but it looks like what this issue
is after)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB9fS2N-QneAjQ3hqhACHarxoYYS_-Tks5sFoiZgaJpZM4CzxMJ>
.
--
*THOMAS BOUTELL, *SUPPORT LEAD
P'UNK AVENUE | (215) 755-1330 | punkave.com
|
Hey guys, I wonder how can I change that message, I tried overide the file
node_modules/apostrophe-moderator/public/js/content.js
intolib/modules/apostrophe-moderator/public/js/content.js
and change that message, but I'm getting browser errorUncaught ReferenceError: MyModerator is not defined
, so how can I overide this message ?and btw, is here i18n for client side ?
if there is where do I define it ?
thanks.
The text was updated successfully, but these errors were encountered: