Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-1130 PRO-1083 trash is really truly unpublished now #2880

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

boutell
Copy link
Member

@boutell boutell commented Apr 5, 2021

No description provided.

@boutell boutell requested a review from abea April 5, 2021 14:32
@linear
Copy link

linear bot commented Apr 5, 2021

PRO-1083 Restored Pieces and Pages should be restored as an unpublished Draft

Edit: Confirming this is not an issue for Pieces. Tested on A3 Demo

  1. Create an Article
  2. Publish it
  3. Archive it
  4. Navigate to the Archive view
  5. Restore the Article
  6. Once restored, you can navigate manually to the Article, and it is a Draft (tho this is difficult to tell)
  7. Filing as a separate bug: Once on the draft page, if you switch to published, you get a 404. You shouldn't be able to switch to Publish. Will follow up

Confirming that this is an issue for Pages

  1. Repeat similar steps for pieces
  2. Pages seem to automatically be published.

Copy link
Contributor

@abea abea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small formatting improvement

Comment on lines 142 to 143
// Mark draft only after moving to trash, to reactivate UI associated with
// things never published before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Mark draft only after moving to trash, to reactivate UI associated with
// things never published before
// Mark draft only after moving to trash, to reactivate UI
// associated with things never published before

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns to 80 chars

@boutell boutell requested a review from abea April 5, 2021 17:56
@boutell boutell changed the title PRO-1083 trash is really truly unpublished now PRO-1130 PRO-1083 trash is really truly unpublished now Apr 5, 2021
@linear
Copy link

linear bot commented Apr 5, 2021

PRO-1130 Restored Pieces: Not following established patterns

When a piece is trashed and then restored, there are two aberrations from established patterns

  1. The DRAFT document is not demarcated as such. It looks exactly like any other published document in the manager. Due to the changes we'll be making to this, I suggest we leave this alone, for now, and deal with it when the design change is applied.
  2. When opening a restored draft, the primary action is "Publish Changes", when it should be "Published. We should fix this before the design change, since its unrelated.

@boutell boutell merged commit ee64d95 into 3.0 Apr 5, 2021
@abea abea deleted the 3/pro-1083-trash-is-unpublished branch April 14, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants