Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iPhone Developer by default #166

Merged
merged 4 commits into from
May 13, 2019

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented May 13, 2019

I got feedback about manual code signing by a friend of mine.

Below error can happen with Appium 1.13.0 while Appium 1.12 had no issue about it.
Once we do auto signing, this did not happen.

	No profiles for 'com.kazucocoa.WebDriverAgent' were found: Xcode couldn't find any iOS App Development provisioning profiles matching 'com.kazucocoa.WebDriverAgent'. Automatic signing is disabled and unable to generate a profile. To enable automatic signing, pass -allowProvisioningUpdates to xcodebuild. (in target 'WebDriverAgentRunner')
	No signing certificate "iOS Development" found: No "iOS Development" signing certificate matching team ID "xxxxxxx" with a private key was found. (in target 'WebDriverAgentLib')
	WebDriverAgentRunner:
		WebDriverAgentRunner-Runner.app encountered an error (Failed to install or launch the test runner. (Underlying error: The file “WebDriverAgentRunner-Runner.app” couldn’t be opened because there is no such file. The file doesn’t exist. (Underlying error: The operation couldn’t be completed. No such file or directory)))
Test session results and logs:

I removed tvOS related the default value in https://github.com/appium/WebDriverAgent/pull/159/files, but maybe something missing in iPhone? or it's safer to add "iPhone Developer" as the default value for iPhone build.


Original FB repo
https://github.com/facebookarchive/WebDriverAgent/blob/c233bf0776f87e5a589a83e688508c383b0cdb34/WebDriverAgent.xcodeproj/project.pbxproj

@KazuCocoa
Copy link
Member Author

KazuCocoa commented May 13, 2019

I've tested 401a9aa:

  • real device iPhone/tvOS with code signing (no regressions)
  • real iPhone as another signing (my friend's env) (fix the issue)

The current setting should work as same as 1.12

@KazuCocoa
Copy link
Member Author

KazuCocoa commented May 13, 2019

@dpgraham
Do we have a chance to add this in 1.13.1 hotfix release?
This affects some real device users who run codesign by manual by capabilities or xcconfig. By this issue, maybe they failed to build WDA.

(If the release will be soon, it's fine to add this in next cycle.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants