Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update CocoaAsyncSocket to 7.6.4 #349

Merged
merged 4 commits into from
Jun 12, 2020

Conversation

qmfrederik
Copy link

The copy of CocoaAsyncSocket in CocoaHTTPserver was 7 years old. Update to version 7.6.4, which is 3 months old.

@qmfrederik
Copy link
Author

qmfrederik commented Jun 12, 2020

A better way to do this is probably to use Carthage. I tried adding CocoaAsyncSockets as a Carthage dependency, but Xcode complained because CocoaAsyncSockets.h includes an @import Foundation statement. Appears to be related to this:

Xcode 11.4 turns the -Watimport-in-framework-header warning on by default. Using @import in framework headers is discouraged, because doing so requires all importers to use modules. (59222634) (FB7566046)

@qmfrederik qmfrederik changed the title [build] Update CocoaAsyncSocket to 7.6.4 build: Update CocoaAsyncSocket to 7.6.4 Jun 12, 2020
@mykola-mokhnach
Copy link

I tried adding CocoaAsyncSockets as a Carthage dependency, but Xcode complained because CocoaAsyncSockets.h includes an @import Foundation statement.

I think it is fine to disable warnings for such kind of issues in project opts

@mykola-mokhnach
Copy link

and add the lib to carthage

@KazuCocoa KazuCocoa merged commit 1f49328 into appium:master Jun 12, 2020
KazuCocoa added a commit that referenced this pull request Jun 12, 2020
mykola-mokhnach pushed a commit that referenced this pull request Jun 12, 2020
@qmfrederik qmfrederik deleted the fixes/update-cocoa-async-socket branch June 13, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants