Add screenrecord to adb commands #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
reviewed
Jul 27, 2018
lib/tools/adb-commands.js
Outdated
| cmd.push('--bugreport'); | ||
| } | ||
| cmd.push(destination); | ||
| return new SubProcess(this.executable.path, [ |
There was a problem hiding this comment.
we're intentionally just returning the process obj and not starting it?
There was a problem hiding this comment.
yes, we need full control over it. See https://github.com/appium/appium-android-driver/pull/399/files for more details
dpgraham
approved these changes
Jul 27, 2018
jlipps
approved these changes
Jul 27, 2018
added 2 commits
July 27, 2018 22:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume it would be smarter to wrap this command here up for further usage in appium/appium-android-driver#399