uninstall espresso server if the installed server version is newer #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (appState === this.adb.APP_INSTALL_STATE.NEWER_VERSION_INSTALLED) { | ||
| await this.adb.uninstallApk(TEST_APK_PKG); | ||
| } | ||
|
|
||
| await this.adb.installOrUpgrade(this.modServerPath, TEST_APK_PKG); |
There was a problem hiding this comment.
regarding the cost of getApplicationInstallState call - it is called inside installOrUpgrade for the second time. This means we should consider changing installOrUpgrade to install, like UIA2 driver does if the upgrade logic needs to be customized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appium/appium-uiautomator2-driver#270 for Espresso.
installOrUpgradeincludes the same, lower version and unknown cases. The only newer version does not exist in the method.I considered implementing
uninstallApkwhen installed app isNEWER_VERSION_INSTALLEDininstallOrUpgrade. But current behaviour is proper for the current method name. The cost of callinggetApplicationInstallStateis not considerable, I thought.Thus, I add this way.