-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mobile endpoint to retrieve UIAutomator page source dump #628
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4a55e83
Add enpoint for page source with uiautomator
pr4bh4sh 22599fe
Correct HTTP method
pr4bh4sh 2ee3155
Add 'uiautomatorPageSource' command mapping
pr4bh4sh abd8001
Address review comments
pr4bh4sh 084b15d
Address review comments
pr4bh4sh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
44 changes: 44 additions & 0 deletions
44
...r/app/src/androidTest/java/io/appium/espressoserver/lib/handlers/UiautomatorPageSource.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* See the NOTICE file distributed with this work for additional | ||
* information regarding copyright ownership. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.appium.espressoserver.lib.handlers | ||
|
||
import io.appium.espressoserver.lib.handlers.exceptions.AppiumException | ||
import io.appium.espressoserver.lib.helpers.InteractionHelper | ||
import io.appium.espressoserver.lib.model.AppiumParams | ||
import java.io.File | ||
|
||
class UiautomatorPageSource : RequestHandler<AppiumParams, String> { | ||
|
||
@Throws(AppiumException::class) | ||
override fun handleInternal(params: AppiumParams): String { | ||
var dumpXml = "" | ||
var dumpView: File? = null | ||
|
||
try { | ||
val uiDevice = InteractionHelper.getUiDevice() | ||
mykola-mokhnach marked this conversation as resolved.
Show resolved
Hide resolved
|
||
dumpView = File.createTempFile("window_dump", "uix") | ||
uiDevice.dumpWindowHierarchy(dumpView) | ||
mykola-mokhnach marked this conversation as resolved.
Show resolved
Hide resolved
|
||
dumpXml = dumpView.inputStream().readBytes().toString(Charsets.UTF_8) | ||
dumpView.delete() | ||
mykola-mokhnach marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} catch (e: Exception) { | ||
throw AppiumException("Could not get page source with UiAutomator", e) | ||
} finally { | ||
dumpView?.delete() | ||
} | ||
return dumpXml | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kotlin allows to return directly from try: https://kotlinlang.org/docs/reference/exceptions.html#try-is-an-expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method could be simplified as
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done