Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Failed index still gives "Index Created" message #430

Closed
2 tasks done
Sirius3615 opened this issue May 2, 2023 · 6 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Sirius3615
Copy link

👟 Reproduction steps

When I make an Index that would throw an error/fail it shows it failed but it also pops a small banner in the top right corner saying the index was created with a green tick, seems a bit off.

👍 Expected behavior

It should either change the banner to something that would indicate it failed or not show it at all.

👎 Actual Behavior

Screen.Recording.2023-05-02.at.23.05.15.mov

🎲 Appwrite version

Version 1.3.x

💻 Operating system

MacOS

🧱 Your Environment

Appwrite Cloud Console (In Safari)

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@Sirius3615 Sirius3615 added the bug Something isn't working label May 2, 2023
@joeyouss
Copy link

Thank you for opening this. I have conveyed this to my team

@joeyouss joeyouss changed the title 🐛 Bug Report: 🐛 Bug Report: Failed index still gives "Index Created" message May 19, 2023
@stnguyen90
Copy link
Contributor

@Sirius3615, I can see how

Index has been created

can be confusing/misleading. Since the index creation is done in the background by a worker, we should change this to:

Creating index

@stnguyen90 stnguyen90 added the good first issue Good for newcomers label Jul 28, 2023
@Chaitanya-Upadhye
Copy link
Contributor

can be confusing/misleading. Since the index creation is done in the background by a worker, we should change this to:

Creating index

Should the notification be of the type info in this case ? since we are not certain of the outcome?

Would someone be able to assign this to me? I can take this up! @joeyouss @stnguyen90

@joeyouss
Copy link

@Chaitanya-Upadhye please go ahead

@stnguyen90
Copy link
Contributor

Should the notification be of the type info in this case ? since we are not certain of the outcome?

No, it should still be success because the request to create the index was successful.

Chaitanya-Upadhye added a commit to Chaitanya-Upadhye/console that referenced this issue Aug 1, 2023
eldadfux added a commit that referenced this issue Aug 8, 2023
…essage

fix(#430): Change success message to 'Creating Index' for better user…
@krishnaa192
Copy link

Still, this issue is Open or not? If open can you assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants