Fix feedback #1645
Merged
Fix feedback #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernstmul
reviewed
Feb 10, 2025
|
|
||
| <div class="mobile-feedback-dialog-modal"> | ||
| <Modal title="Feedback" bind:show={$feedback.show} dismissible={false}> | ||
| <Feedback isMobile /> |
There was a problem hiding this comment.
Where is this isMobile property set?
There was a problem hiding this comment.
here, in the feedback.svelte component.
src/routes/(console)/wizard/feedback/mobileFeedbackModal.svelte
Outdated
Show resolved
Hide resolved
| {#if $feedbackData.value !== null} | ||
| <!-- TODO: @itznotabug, helper is a plain string atm, cannot add html/anchor for Discord link --> |
There was a problem hiding this comment.
yeah, currently the html content isn't supported on helper.
ernstmul
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes feedback as per pink2.
Test Plan
Manual.
Related PRs and Issues
N/A.
Have you read the Contributing Guidelines on issues?
Yes.