Feat: null value fields #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Related Issue: appwrite/appwrite#4712 |
|
The behavior looks good for
|
|
null for enum also looks good:
|
stnguyen90
requested changes
Mar 31, 2023
...roject-[project]/databases/database-[database]/collection-[collection]/createDocument.svelte
Outdated
Show resolved
Hide resolved
...oject-[project]/databases/database-[database]/collection-[collection]/attributes/enum.svelte
Outdated
Show resolved
Hide resolved
...ect-[project]/databases/database-[database]/collection-[collection]/attributes/string.svelte
Outdated
Show resolved
Hide resolved
...bases/database-[database]/collection-[collection]/document-[document]/attributes/enum.svelte
Show resolved
Hide resolved
2 tasks
ArmanNik
requested changes
Apr 6, 2023
...ses/database-[database]/collection-[collection]/document-[document]/attributes/string.svelte
Outdated
Show resolved
Hide resolved
Comment on lines
+72
to
+73
| <ul | ||
| class="buttons-list u-gap-8 u-cross-center u-position-absolute d u-inset-block-end-1 u-inset-inline-end-1 u-padding-block-8 u-padding-inline-12" |
There was a problem hiding this comment.
Is it worth creating a "inputButtonContainer" component to avoid repeating all these classes?
There was a problem hiding this comment.
Maybeee, but if so we should probably do it in pink, right?
TGlide
force-pushed
the
feat/null-value-fields
branch
from
0c12150 to
2c57014
Compare
stnguyen90
approved these changes
Apr 11, 2023
TorstenDittmann
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
Manual
Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
Yes