Add a generic OIDC OAuth2 provider

[stnguyen90]

What does this PR do?

Add an OIDC OAuth2 Provider to the Console

Test Plan

Related PRs and Issues

• 🚀 Feature: OAuth support for OIDC providers (Keycloak, and more) appwrite#4299
• Add a generic OIDC OAuth2 provider appwrite#5449

Have you read the Contributing Guidelines on issues?

Yes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 31, 2023 5:09pm
console-cloud	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 31, 2023 5:09pm
console-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 31, 2023 5:09pm

[TorstenDittmann]

lets wait for backend PR 👍🏻

[binaryfire]

Nice work @stnguyen90. Hoping this gets merged soon. Will be great to have Keycloak support.

[eldadfux]

It should be OIDC in the UI, and not Oidc

[stnguyen90]

It should be OIDC in the UI, and not Oidc

@eldadfux, the API returns Oidc for the name and we use that in the Console:

console/src/routes/console/project-[project]/auth/settings/+page.svelte

Line 88 in 8fdaaf2

<p class="u-margin-block-start-8">{provider.name}</p>

We would have to add and maintain a list of exceptions in the console repo somewhere. That okay?

[eldadfux]

It should be OIDC in the UI, and not Oidc

@eldadfux, the API returns Oidc for the name and we use that in the Console:

console/src/routes/console/project-[project]/auth/settings/+page.svelte

Line 88 in 8fdaaf2

<p class="u-margin-block-start-8">{provider.name}</p>

We would have to add and maintain a list of exceptions in the console repo somewhere. That okay?

I think we should avoid that. I think we need to find a better way to expose the name, which endpoint do we use for getting it right now?

[stnguyen90]

I think we should avoid that. I think we need to find a better way to expose the name, which endpoint do we use for getting it right now?

@eldadfux, it comes from the List/Get Projects endpoints. The providers attribute is a list of providers where name is the provider key.

https://github.com/appwrite/appwrite/blob/e12a5738aa56bcbb6dc41c8b5b0d201bb2eae5e7/src/Appwrite/Utopia/Response/Model/Project.php#L276

Btw, our setup is really limiting since it makes it so that we can only have 1 of each OAuth2 provider.

[eldadfux]

I don't see a reason why we can't use the key for getting the name. If needed we can also add new key attribute. This API is also private for the console so we should be OK with the change.

https://github.com/appwrite/appwrite/blob/e12a5738aa56bcbb6dc41c8b5b0d201bb2eae5e7/src/Appwrite/Utopia/Response/Model/Project.php#L276

[stnguyen90]

I don't see a reason why we can't use the key for getting the name. If needed we can also add new key attribute. This API is also private for the console so we should be OK with the change.

@eldadfux, here's a PR to add the provider key to the response: appwrite/appwrite#5857

[stnguyen90]

@TorstenDittmann, anything else before this can be merged?

[stnguyen90]

@TorstenDittmann is this good to merge now?