Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: less repetitive entries for prerelease changelogs #37

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

apricote
Copy link
Owner

@apricote apricote commented Aug 30, 2024

Right now we always show all new releasable commits since the last stable release.

If a project publishes multiple pre-releases in a row, they all repeat the same lines with a few new additions.

On the other hand, when we cut a stable release, we do want to show all changes since the last stable release, as we can not expect users to read the changelog of pre-releases.

As a compromise, the code now looks at the type of release that is being created, and decides based on that if we will look at STABLE..HEAD (stable release) or LATEST..HEAD (pre-release).

Close #33

 feat: less repetitive entries for prerelease changelogs #37 

@apricote apricote added the enhancement New feature or request label Aug 30, 2024
@apricote apricote self-assigned this Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 9.04%. Comparing base (693ca21) to head (4c332b3).

Files with missing lines Patch % Lines
releasepr.go 0.00% 8 Missing ⚠️
releaserpleaser.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #37      +/-   ##
========================================
- Coverage   9.11%   9.04%   -0.07%     
========================================
  Files         17      17              
  Lines       1459    1470      +11     
========================================
  Hits         133     133              
- Misses      1319    1330      +11     
  Partials       7       7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Right now we always show all new releasable commits since the last
_stable_ release.

If a project publishes multiple pre-releases in a row, they all repeat
the same lines with a few new additions.

On the other hand, when we cut a stable release, we do want to show all
changes since the last stable release, as we can not expect users to
read the changelog of pre-releases.

As a compromise, the code now looks at the type of release that is being
created, and decides based on that if we will look at STABLE..HEAD
(stable release) or LATEST..HEAD (pre-release).

Close #33
@apricote apricote force-pushed the prerelease-changelog branch from 106f88b to 4c332b3 Compare August 30, 2024 17:40
@apricote apricote merged commit 971b6e6 into main Aug 30, 2024
3 checks passed
@apricote apricote deleted the prerelease-changelog branch August 30, 2024 17:44
@apricote apricote changed the title feat: less repetitive entries for for prerelease changelogs feat: less repetitive entries for prerelease changelogs Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Restrict the pre-release changelog to changes since the last pre-release
2 participants