Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): container image reference used wrong syntax #96

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

apricote
Copy link
Owner

@apricote apricote commented Nov 8, 2024

The current value caused the following error when running the action in a different repository:

Error: 'ghcr.io/apricote/releaser-pleaser:v0.4.1' should be either '[path]/Dockerfile' or 'docker://image[:tag]'.

Not sure why this did not come up before, as we are also using the same format for the CI in this repository, even if we use another tag.

The current value caused the following error when running the action in
a different repository:

    Error: 'ghcr.io/apricote/releaser-pleaser:v0.4.1' should be either '[path]/Dockerfile' or 'docker://image[:tag]'.

Not sure why this did not come up before, as we are also using the same
format for the CI in this repository, even if we use another tag.
@apricote apricote added the bug Something isn't working label Nov 8, 2024
@apricote apricote self-assigned this Nov 8, 2024
@apricote apricote enabled auto-merge (squash) November 8, 2024 12:26
@apricote apricote merged commit cbfacc8 into main Nov 8, 2024
4 checks passed
@apricote apricote deleted the action-docker-ref branch November 8, 2024 12:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.19%. Comparing base (7135114) to head (4921114).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   24.19%   24.19%           
=======================================
  Files          22       22           
  Lines        1645     1645           
=======================================
  Hits          398      398           
  Misses       1228     1228           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Nov 8, 2024
…etznercloud/fleeting-plugin-hetzner!162)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [apricote/releaser-pleaser](https://gitlab.com/apricote/releaser-pleaser) | repository | patch | `v0.4.1` -> `v0.4.2` |

---

### Release Notes

<details>
<summary>apricote/releaser-pleaser (apricote/releaser-pleaser)</summary>

### [`v0.4.2`](https://gitlab.com/apricote/releaser-pleaser/blob/HEAD/CHANGELOG.md#v042)

[Compare Source](https://gitlab.com/apricote/releaser-pleaser/compare/v0.4.1...v0.4.2)

##### Bug Fixes

-   **action**: container image reference used wrong syntax ([#&#8203;96](apricote/releaser-pleaser#96))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44LjAiLCJ1cGRhdGVkSW5WZXIiOiIzOS44LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants