Fixed accord-net#706

ar7z1 · Jul 13, 2017 · c507a51 · c507a51
1 parent 14b6efd
commit c507a51
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 1 deletion.
diff --git a/Sources/Accord.MachineLearning/DecisionTrees/DecisionTreeWriter.cs b/Sources/Accord.MachineLearning/DecisionTrees/DecisionTreeWriter.cs
@@ -60,7 +60,7 @@ public void Write(DecisionTree tree, string className)
             writer.WriteLine("namespace DecisionTrees");
             writer.WriteLine("{");
             writer.WriteLine("    using System.CodeDom.Compiler;");
-            writer.WriteLine("    using System.Collections.Generic;");
+            writer.WriteLine("    using System;");
             writer.WriteLine();
             writer.WriteLine("    /// <summary>");
             writer.WriteLine("    ///   Automatically generated decision tree.");

diff --git a/Unit Tests/Accord.Tests.MachineLearning/Accord.Tests.MachineLearning.csproj b/Unit Tests/Accord.Tests.MachineLearning/Accord.Tests.MachineLearning.csproj
@@ -73,6 +73,7 @@
     <Compile Include="..\..\Samples\MachineLearning\Liblinear %28SVMs%29\Train.cs">
       <Link>VectorMachines\Liblinear\Train.cs</Link>
     </Compile>
+    <Compile Include="DecisionTrees\DecisionTreeWriterTest.cs" />
     <Compile Include="POSTest.cs" />
     <Compile Include="TFIDFTest.cs" />
     <Compile Include="BagOfWordsTest.cs" />

diff --git a/Unit Tests/Accord.Tests.MachineLearning/DecisionTrees/DecisionTreeWriterTest.cs b/Unit Tests/Accord.Tests.MachineLearning/DecisionTrees/DecisionTreeWriterTest.cs
@@ -0,0 +1,36 @@
+using System.CodeDom.Compiler;
+using System.Text;
+using Accord.MachineLearning.DecisionTrees;
+using Microsoft.CSharp;
+using NUnit.Framework;
+
+namespace Accord.Tests.MachineLearning
+{
+    [TestFixture]
+    public class DecisionTreeWriterTest
+    {
+        [Test]
+        public void WriteTest()
+        {
+            DecisionTree tree;
+            int[][] inputs;
+            int[] outputs;
+            ID3LearningTest.CreateMitchellExample(out tree, out inputs, out outputs);
+
+            var csc = new CSharpCodeProvider();
+            var parameters = new CompilerParameters(new[] { "System.dll", "mscorlib.dll" }) {GenerateInMemory = true};
+
+            var compilerResult = csc.CompileAssemblyFromSource(parameters, tree.ToCode("AccordDecisionTree"));
+
+            Assert.That(compilerResult.Errors.HasErrors, Is.False, ToString(compilerResult.Errors));
+        }
+
+        private static string ToString(CompilerErrorCollection compilerErrors)
+        {
+            var builder = new StringBuilder("Compiler errors:\n");
+            foreach (var error in compilerErrors)
+                builder.AppendLine(error.ToString());
+            return builder.ToString();
+        }
+    }
+}