Clean up K_T and K_P. #2428
Open
Clean up K_T and K_P. #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaherrera
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Hi @thorstenhater,
There is a mistake in the K_P.mod definition (see comment on L49). The rest of the mechanisms look good.
Best,
Beatriz
| } | ||
|
|
||
| h_rho = qt/(360 + (1010 + 24*(v + 55 - vshift))*exp(-((v + 75 - vshift)/48)^2)) | ||
| m_rho = qt/(tauF*(1.25 + m_z)) | ||
| h_rho = qt/((24*vs + 2690)*exp(-((vs + 75)/48)^2)) |
There was a problem hiding this comment.
It should be h_rho = qt/(360 + (24*vs + 2330)*exp(-(((vs + 75)/48)^2))) since '360' doesn't multiply the exponential term in the original definition.
There was a problem hiding this comment.
Yes, good catch, thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qt