-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] Add tenant parameter to defaults()
in UrlGeneratorBootstrapper
#1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate tests accordingly (wip)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1311 +/- ##
============================================
+ Coverage 84.67% 84.71% +0.03%
- Complexity 1054 1056 +2
============================================
Files 177 177
Lines 3086 3094 +8
============================================
+ Hits 2613 2621 +8
Misses 473 473 ☔ View full report in Codecov by Sentry. |
defaults()
in UrlGeneratorBootstrapper
defaults()
in UrlGeneratorBootstrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the UrlGeneratorBootstrapper and the TenancyUrlGenerator clearer and overall more useful (e.g. simplifies using Ziggy's
route()
helper with path identification, in response to #1302, note: update Ziggyroute()
integration documentation for both the path and the query string identification).UrlGeneratorBootstrapper
The
route()
helper receives the tenant parameter automatically. This is achieved by adding the tenant parameter toURL::defaults()
inUrlGeneratorBootstrapper
.This behavior can be disabled by setting
UrlGeneratorBootstrapper::$addTenantParameterToDefaults
tofalse
.TenancyUrlGenerator
The TenancyUrlGenerator now
route()
by defaultTenancyUrlGenerator is intended to be configured in two cases:
route()
helper with thetenant.
prefix automatically (set the static$prefixRouteNames
property totrue
)$passTenantParameterToRoutes
totrue
-- this is needed with query string identification, sinceURL::defaults()
only works for route parameters)With path identification, you can also opt out of adding the tenant parameter to the defaults by setting
UrlGeneratorBootstrapper::$addTenantParameterToDefaults
tofalse
and make TenancyUrlGenerator pass the tenant parameter instead by settingTenancyUrlGenerator::$passTenantParameterToRoutes
totrue
(e.g. in TenancyServiceProvider).The UrlGeneratorBootstrapper tests are also simplified and updated accordingly.