fix(utils): DefaultLogger does not trim messages by default and accep…

…ts more truthy strings for DEBUG env var (#7467)

.changeset/gorgeous-moons-sleep.md

@@ -0,0 +1,12 @@
+---
+'@graphql-mesh/utils': minor
+---
+
+Trimming log messages is an option independant of the DEBUG environment variable.
+
+Instead of trimming messages at 100 characters by default when the `DEBUG` environment variable is falsy, have the user configure the trim length that is not set by default.
+
+```js
+import { DefaultLogger } from '@graphql-mesh/utils';
+const trimmedLogger = new DefaultLogger('my-logger', undefined, 100 /* trim at 100 characters*/);
+``

.changeset/twenty-apes-refuse.md

@@ -0,0 +1,5 @@
+---
+'@graphql-mesh/utils': patch
+---
+
+Accept '1', 't', 'true', 'y' and 'yes' as truthy values for DEBUG environment variable

packages/legacy/utils/src/logger.ts

@@ -33,26 +33,31 @@ export enum LogLevel {
 
 const noop: VoidFunction = () => {};
 
+function truthy(str: unknown) {
+  return str === true || str === 1 || ['1', 't', 'true', 'y', 'yes'].includes(String(str));
+}
+
 function getTimestamp() {
   return new Date().toISOString();
 }
 
 export class DefaultLogger implements Logger {
   constructor(
     public name?: string,
-    public logLevel = process.env.DEBUG === '1' ? LogLevel.debug : LogLevel.info,
+    public logLevel = truthy(process.env.DEBUG) ? LogLevel.debug : LogLevel.info,
+    private trim?: number,
   ) {}
 
-  private getLoggerMessage({ args = [], trim = !this.isDebug }: { args: any[]; trim?: boolean }) {
+  private getLoggerMessage({ args = [] }: { args: any[] }) {
     return args
       .flat(Infinity)
       .map(arg => {
         if (typeof arg === 'string') {
-          if (trim && arg.length > 100) {
+          if (this.trim && arg.length > this.trim) {
             return (
-              arg.slice(0, 100) +
+              arg.slice(0, this.trim) +
               '...' +
-              '<Message is too long. Enable DEBUG=1 to see the full message.>'
+              '<Message is trimmed. Enable DEBUG=1 to see the full message.>'
             );
           }
           return arg;
@@ -61,27 +66,24 @@ export class DefaultLogger implements Logger {
         }
         return util.inspect(arg);
       })
-      .join(` `);
+      .join(' ');
   }
 
-  private handleLazyMessage({ lazyArgs, trim }: { lazyArgs: LazyLoggerMessage[]; trim?: boolean }) {
+  private handleLazyMessage({ lazyArgs }: { lazyArgs: LazyLoggerMessage[] }) {
     const flattenedArgs = lazyArgs.flat(Infinity).flatMap(arg => {
       if (typeof arg === 'function') {
         return arg();
       }
       return arg;
     });
-    return this.getLoggerMessage({
-      args: flattenedArgs,
-      trim,
-    });
+    return this.getLoggerMessage({ args: flattenedArgs });
   }
 
   private get isDebug() {
     if (process.env.DEBUG) {
       return (
-        process.env.DEBUG === '1' ||
-        (globalThis as any).DEBUG === '1' ||
+        truthy(process.env.DEBUG) ||
+        truthy((globalThis as any).DEBUG) ||
         this.name.includes(process.env.DEBUG || (globalThis as any).DEBUG)
       );
     }
@@ -96,9 +98,7 @@ export class DefaultLogger implements Logger {
     if (this.logLevel > LogLevel.info) {
       return noop;
     }
-    const message = this.getLoggerMessage({
-      args,
-    });
+    const message = this.getLoggerMessage({ args });
     const fullMessage = `[${getTimestamp()}] ${this.prefix} ${message}`;
     if (process?.stderr?.write(fullMessage + '\n')) {
       return;
@@ -110,9 +110,7 @@ export class DefaultLogger implements Logger {
     if (this.logLevel > LogLevel.warn) {
       return noop;
     }
-    const message = this.getLoggerMessage({
-      args,
-    });
+    const message = this.getLoggerMessage({ args });
     const fullMessage = `[${getTimestamp()}] ${this.prefix} WARN  ${warnColor(message)}`;
     if (process?.stderr?.write(fullMessage + '\n')) {
       return;
@@ -139,10 +137,7 @@ export class DefaultLogger implements Logger {
     if (this.logLevel > LogLevel.error) {
       return noop;
     }
-    const message = this.getLoggerMessage({
-      args,
-      trim: false,
-    });
+    const message = this.getLoggerMessage({ args });
     const fullMessage = `[${getTimestamp()}] ERROR ${this.prefix} ${errorColor(message)}`;
     if (typeof process?.stderr?.write === 'function') {
       process.stderr.write(fullMessage + '\n');