refactor(anta.tests): Nicer result failure messages interface(part -1) test module #1045
+54
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1045 will not alter performanceComparing Summary
|
geetanjalimanegslab
changed the title
vitthalmagadum
requested changes
Feb 20, 2025
vitthalmagadum
approved these changes
Feb 24, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
carl-baillargeon
requested changes
Feb 25, 2025
| @@ -653,7 +656,7 @@ | |||
| "inputs": {"threshold": 70.0}, | |||
| "expected": { | |||
| "result": "failure", | |||
| "messages": ["Interface Ethernet1/1 or one of its member interfaces is not Full-Duplex. VerifyInterfaceUtilization has not been implemented."], | |||
| "messages": ["Interface: Ethernet1/1 - Interface utilization has not been implemented"], | |||
There was a problem hiding this comment.
We should keep the mention about is not full-duplex and the test name.
Comment on lines
804
to
807
| "messages": [ | ||
| "Interface: Port-Channel31 MemberInterface: Ethernet3/1 - Not Full-Duplex - Actual: duplexHalf", | ||
| "Interface: Port-Channel31 MemberInterface: Ethernet4/1 - Not Full-Duplex - Actual: duplexHalf", | ||
| ], |
There was a problem hiding this comment.
Same comment as above. I think for this specific use case it's fine to have a single failure message like before.
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nicer result failure messages Interface test module following testcases are covers.
Description
Fixes #587
Checklist:
pre-commit run)tox -e testenv)