Feat(eos_designs): Add support for RSS interface profile for select p…

…latforms Updated unit tests and addressed review feedback for more information, see https://pre-commit.ci
aristanetworks · Feb 26, 2025 · 2245499 · 2245499
1 parent 54d34bc
commit 2245499
Show file tree

Hide file tree

Showing 18 changed files with 1,788 additions and 366 deletions.
diff --git a/...signs_negative_unit_tests/inventory/host_vars/rss-profile-duplicate-interface-members.yml b/...signs_negative_unit_tests/inventory/host_vars/rss-profile-duplicate-interface-members.yml
@@ -0,0 +1,27 @@
+---
+type: l3leaf
+l3leaf:
+  defaults:
+    platform: AWE-5510
+  nodes:
+    - bgp_as: 65000
+      name: rss-profile-duplicate-interface-members
+      id: 1
+      loopback_ipv4_pool: 192.168.0.0/24
+      vtep_loopback_ipv4_pool: 192.168.1.0/24
+      l3_interfaces:
+        - name: Ethernet1/19
+          ip_address: 172.16.0.3/30
+          rx_queue:
+            count: 2
+      l3_port_channels:
+        - name: Port-Channel5
+          ip_address: 172.16.0.2/30
+          member_interfaces:
+            - name: Ethernet1/19
+              rx_queue:
+                mode: exclusive
+
+expected_error_message: >-
+  Found duplicate objects with conflicting data while generating configuration for Port-Channel member interface defined with RSS settings.
+  {'name': 'Ethernet1/19', 'rx_queue': {'mode': 'exclusive'}} conflicts with {'name': 'Ethernet1/19', 'rx_queue': {'count': 2}}.
diff --git a/...s_designs_negative_unit_tests/inventory/host_vars/rss-profile-exceed-max-rx-queue-cnt.yml b/...s_designs_negative_unit_tests/inventory/host_vars/rss-profile-exceed-max-rx-queue-cnt.yml
@@ -0,0 +1,21 @@
+---
+type: l3leaf
+l3leaf:
+  defaults:
+    platform: AWE-5310
+  nodes:
+    - bgp_as: 65000
+      name: rss-profile-exceed-max-rx-queue-cnt
+      id: 1
+      loopback_ipv4_pool: 192.168.0.0/24
+      vtep_loopback_ipv4_pool: 192.168.1.0/24
+      l3_port_channels:
+        - name: Port-Channel5
+          ip_address: 172.16.0.2/30
+          member_interfaces:
+            - name: Ethernet1/19
+              rx_queue:
+                count: 10
+
+expected_error_message: >-
+  'rx_queue' count for interface 'Ethernet1/19' exceeds maximum supported '6' for this platform.
diff --git a/.../eos_designs_negative_unit_tests/inventory/host_vars/rss-profile-worker-id-exceed-max.yml b/.../eos_designs_negative_unit_tests/inventory/host_vars/rss-profile-worker-id-exceed-max.yml
@@ -0,0 +1,23 @@
+---
+type: l3leaf
+l3leaf:
+  defaults:
+    platform: AWE-5510
+  nodes:
+    - bgp_as: 65000
+      name: rss-profile-worker-id-exceed-max
+      id: 1
+      loopback_ipv4_pool: 192.168.0.0/24
+      vtep_loopback_ipv4_pool: 192.168.1.0/24
+      l3_port_channels:
+        - name: Port-Channel5
+          ip_address: 172.16.0.2/30
+          member_interfaces:
+            - name: Ethernet1/19
+              rx_queue:
+                worker:
+                  - 2
+                  - 14-17
+
+expected_error_message: >-
+  One or more worker ids within '14-17' under 'rx_queue' for interface 'Ethernet1/19' equal or exceed maximum supported '16' for this platform.
diff --git a/ansible_collections/arista/avd/molecule/eos_designs_negative_unit_tests/inventory/hosts.yml b/ansible_collections/arista/avd/molecule/eos_designs_negative_unit_tests/inventory/hosts.yml
@@ -130,6 +130,9 @@ all:
             missing-wan-router-l3-interfaces-ip-address:
             ntp-settings-server-vrf-missing-mgmt-ip:
             ntp-settings-server-vrf-missing-inband-mgmt-interface:
+            rss-profile-duplicate-interface-members:
+            rss-profile-exceed-max-rx-queue-cnt:
+            rss-profile-worker-id-exceed-max:
             source-interfaces-domain-lookup-duplicate-vrf:
             source-interfaces-domain-lookup-missing-inband-mgmt-interface:
             source-interfaces-domain-lookup-missing-mgmt-ip:

diff --git a/...tions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/rss-profile-options.cfg b/...tions/arista/avd/molecule/eos_designs_unit_tests/intended/configs/rss-profile-options.cfg
@@ -0,0 +1,161 @@
+!
+no enable password
+no aaa root
+!
+vlan internal order ascending range 1006 1199
+!
+transceiver qsfp default-mode 4x10G
+!
+platform sfe interface
+   interface profile Default_RSS_Profile
+   !
+   profile Default_RSS_Profile
+      interface Ethernet1/10
+         rx-queue worker 5
+      !
+      interface Ethernet2
+         rx-queue count 2
+         rx-queue worker 0,3
+         rx-queue mode shared
+      !
+      interface Ethernet3
+         rx-queue count 2
+      !
+      interface Ethernet5
+         rx-queue worker 1-2,4
+         rx-queue mode shared
+      !
+      interface Ethernet9
+         rx-queue count 3
+         rx-queue mode shared
+!
+service routing protocols model multi-agent
+!
+hostname rss-profile-options
+!
+platform sfe data-plane cpu allocation maximum 3
+!
+vrf instance MGMT
+!
+management api http-commands
+   protocol https
+   no shutdown
+   !
+   vrf MGMT
+      no shutdown
+!
+interface Port-Channel2
+   description Cybercast
+   no shutdown
+   no switchport
+   ip address 192.168.1.102/31
+!
+interface Port-Channel5
+   description StreamFast
+   no shutdown
+   no switchport
+   ip address 192.168.1.105/31
+!
+interface Port-Channel5.108
+   no shutdown
+   encapsulation dot1q vlan 108
+   ip address 192.168.100.115/31
+!
+interface Port-Channel8
+   no shutdown
+   no switchport
+   ip address 192.168.100.125/31
+!
+interface Ethernet1
+   no shutdown
+   channel-group 2 mode active
+!
+interface Ethernet1/4
+   no shutdown
+   channel-group 5 mode passive
+!
+interface Ethernet1/5
+   no shutdown
+   channel-group 5 mode passive
+!
+interface Ethernet1/10
+   description peerDevice3_Ethernet1/10
+   no shutdown
+   channel-group 8 mode on
+!
+interface Ethernet2
+   no shutdown
+   channel-group 2 mode active
+!
+interface Ethernet3
+   no shutdown
+   channel-group 2 mode active
+!
+interface Ethernet5
+   no shutdown
+   no switchport
+   ip address 192.168.1.201/31
+!
+interface Ethernet7
+   no shutdown
+   no switchport
+   ip address dhcp
+   dhcp client accept default-route
+!
+interface Ethernet9
+   description Cybercast
+   no shutdown
+   no switchport
+   ip address 192.168.1.202/31
+!
+interface Loopback0
+   description ROUTER_ID
+   no shutdown
+   ip address 192.168.255.1/32
+!
+interface Loopback1
+   description VXLAN_TUNNEL_SOURCE
+   no shutdown
+   ip address 192.168.142.1/32
+!
+interface Vxlan1
+   description rss-profile-options_VTEP
+   vxlan source-interface Loopback1
+   vxlan udp-port 4789
+!
+ip routing
+no ip routing vrf MGMT
+!
+ip prefix-list PL-LOOPBACKS-EVPN-OVERLAY
+   seq 10 permit 192.168.255.0/24 eq 32
+   seq 20 permit 192.168.142.0/24 eq 32
+!
+route-map RM-CONN-2-BGP permit 10
+   match ip address prefix-list PL-LOOPBACKS-EVPN-OVERLAY
+!
+router bfd
+   multihop interval 300 min-rx 300 multiplier 3
+!
+router bgp 65005
+   router-id 192.168.255.1
+   no bgp default ipv4-unicast
+   maximum-paths 4 ecmp 4
+   neighbor EVPN-OVERLAY-PEERS peer group
+   neighbor EVPN-OVERLAY-PEERS update-source Loopback0
+   neighbor EVPN-OVERLAY-PEERS bfd
+   neighbor EVPN-OVERLAY-PEERS ebgp-multihop 3
+   neighbor EVPN-OVERLAY-PEERS send-community
+   neighbor EVPN-OVERLAY-PEERS maximum-routes 0
+   neighbor IPv4-UNDERLAY-PEERS peer group
+   neighbor IPv4-UNDERLAY-PEERS send-community
+   neighbor IPv4-UNDERLAY-PEERS maximum-routes 12000
+   redistribute connected route-map RM-CONN-2-BGP
+   !
+   address-family evpn
+      neighbor EVPN-OVERLAY-PEERS activate
+   !
+   address-family ipv4
+      no neighbor EVPN-OVERLAY-PEERS activate
+      neighbor IPv4-UNDERLAY-PEERS activate
+!
+end