Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Move ansible-only tests to their own molecule scenario #5100

Open
wants to merge 16 commits into
base: devel
Choose a base branch
from

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Feb 25, 2025

Change Summary

Currently we are excluding from pytest some hosts from eos_designs_unit_tests because they have inline Jinja. This PR separates in a new molecule scenario ansible_only the ansible collection only features so we can also run the rest in pytest and ⬆️ coverage

Component(s) name

ci

Proposed changes

cf summary + new molecule scenario added to CI

How to test

green molecules

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners February 25, 2025 13:54
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5100
# Activate the virtual environment
source test-avd-pr-5100/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@test-move-inline-jinja-to-its-own-role#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,test-move-inline-jinja-to-its-own-role --force
# Optional: Install AVD examples
cd test-avd-pr-5100
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR labels Feb 25, 2025
@gmuloc gmuloc added this to the v5.3.0-dev2 milestone Feb 25, 2025
@gmuloc gmuloc requested review from ClausHolbechArista and a team February 26, 2025 10:24
@carlbuchmann carlbuchmann self-requested a review February 27, 2025 14:52
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants