Refactor(eos_designs): structured_config for prefix_lists #5109
+62
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5109
# Activate the virtual environment
source test-avd-pr-5109/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@refactor_prefix_list#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,refactor_prefix_list --force
# Optional: Install AVD examples
cd test-avd-pr-5109
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
force-pushed
the
refactor_prefix_list
branch
from
4a634b0 to
f72ae41
Compare
Shivani-gslab
requested changes
Feb 27, 2025
python-avd/pyavd/_eos_designs/structured_config/underlay/prefix_lists.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/prefix_lists.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/prefix_lists.py
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Feb 27, 2025
Comment on lines
49
to
50
| subnets = self._vrf_default_ipv4_subnets | ||
| static_routes = self._vrf_default_ipv4_static_routes["static_routes"] |
There was a problem hiding this comment.
Can you check if we can update the return values as class object for these two function
There was a problem hiding this comment.
These functions are being used in other files as well, I would suggest we will do it in another PR when we pick utils.py from our list to refactor.
…x_lists.py Co-authored-by: Shivani-gslab <[email protected]>
…es/prefix_lists.py Co-authored-by: Shivani-gslab <[email protected]>
Vibhu-gslab
force-pushed
the
refactor_prefix_list
branch
from
502a418 to
a6b56e2
Compare
python-avd/pyavd/_eos_designs/structured_config/underlay/prefix_lists.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/prefix_lists.py
Outdated
Show resolved
Hide resolved
…x_lists.py Co-authored-by: laxmikantchintakindi <[email protected]>
laxmikantchintakindi
approved these changes
Feb 28, 2025
MaheshGSLAB
approved these changes
Feb 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor eos_designs structured_config for prefix_lists
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
How to test
Checklist
Repository Checklist